Response headers added by proxy servers missing in CURLINFO_HEADER_SIZE #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
responses. The size of these headers was not taken into account by CURLINFO_HEADER_SIZE before this change.
|
Thanks, now merged in master! |
|
@bagder This is fixed as of which cURL version? |
|
That fix was commit bc6037e which went into curl 7.30.0 |
fabpot
added a commit
to sensiolabs/security-checker
that referenced
this pull request
Feb 28, 2018
… var (tgalopin) This PR was merged into the 4.1 branch. Discussion ---------- Add the possibility to force the used transport using an env var There are some issues with the cURL crawler due to a bug in cURL on old systems (curl/curl#60). It would be nice to be able to force the usage of file_get_contents if needed. Commits ------- 7cf6c8c Add the possibility to force the used transport using an env var
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Often times proxy servers add their own headers (like
HTTP/1.0 200 Connection established) to responses on their way back to the client. The size of these headers was not taken into account when calculatingCURLINFO_HEADER_SIZEbefore the change from this pull request.The problem can be reproduced quite easily using the test program from https://gist.github.com/mj/5102778. In our case the proxy server at
proxy:8080was the default Squid that ships with Debian stable.